-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use old aggregation for 386 only, in 8.10 #11403
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
4fad2e9
to
7ee1a9b
Compare
7ee1a9b
to
754b190
Compare
754b190
to
ea8ddf0
Compare
ea8ddf0
to
d3db658
Compare
This pull request is now in conflicts. Could you fix it @carsonip? 🙏
|
Closing as system tests are, and have been, failing on 32 bit systems regardless of this PR. We are revisiting the need to keep the old aggregation implementation for 386. |
This pull request is now in conflicts. Could you fix it @carsonip? 🙏
|
Motivation/summary
Target branch: 8.10 (PR target branch needs to be updated once 8.10 branch is ready)
This is only for 8.10. Use old aggregation code for 386, and new LSM aggregation code otherwise.
Notes for 386 aggregation:
aggregation.transactions.max_services
is moved toaggregation.max_services
Checklist
apmpackage
have been made)For functional changes, consider:
How to test these changes
To run system tests in 32 bit:
Related issues
Closes #11394